OSDN Git Service

MountService: Prevent NPE with DropBoxManager
authorAdrianDC <radian.dc@gmail.com>
Wed, 18 Nov 2015 18:15:29 +0000 (19:15 +0100)
committerAdrian DC <radian.dc@gmail.com>
Thu, 29 Sep 2016 16:58:53 +0000 (18:58 +0200)
 * "java.lang.NullPointerException: Attempt to invoke virtual
    method 'void android.os.DropBoxManager.addText(java.lang.String,
    java.lang.String)' on a null object reference"

Change-Id: I418ba99caa4f55b184fabee4ad610ca3e5e7c66f
Signed-off-by: AdrianDC <radian.dc@gmail.com>
services/core/java/com/android/server/MountService.java

index 8b19123..88d5a47 100644 (file)
@@ -1192,8 +1192,10 @@ class MountService extends IMountService.Stub
                 final long destroy = Long.parseLong(cooked[6]);
 
                 final DropBoxManager dropBox = mContext.getSystemService(DropBoxManager.class);
-                dropBox.addText(TAG_STORAGE_BENCHMARK, scrubPath(path)
-                        + " " + ident + " " + create + " " + run + " " + destroy);
+                if (dropBox != null) {
+                    dropBox.addText(TAG_STORAGE_BENCHMARK, scrubPath(path)
+                            + " " + ident + " " + create + " " + run + " " + destroy);
+                }
 
                 final VolumeRecord rec = findRecordForPath(path);
                 if (rec != null) {
@@ -1210,8 +1212,10 @@ class MountService extends IMountService.Stub
                 final long time = Long.parseLong(cooked[3]);
 
                 final DropBoxManager dropBox = mContext.getSystemService(DropBoxManager.class);
-                dropBox.addText(TAG_STORAGE_TRIM, scrubPath(path)
-                        + " " + bytes + " " + time);
+                if (dropBox != null) {
+                    dropBox.addText(TAG_STORAGE_TRIM, scrubPath(path)
+                            + " " + bytes + " " + time);
+                }
 
                 final VolumeRecord rec = findRecordForPath(path);
                 if (rec != null) {