net: dpaa2-mac: use correct interface to free mdiodev

Rather than using put_device(&mdiodev->dev), use the proper interface
provided to dispose of the mdiodev - that being mdio_device_free().

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Tested-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Link: https://lore.kernel.org/r/E1q2VsB-008QlZ-El@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
index b1871e6..cb70855 100644 (file)
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
@@ -273,7 +273,7 @@ static int dpaa2_pcs_create(struct dpaa2_mac *mac,
        mac->pcs = lynx_pcs_create(mdiodev);
        if (!mac->pcs) {
                netdev_err(mac->net_dev, "lynx_pcs_create() failed\n");
-               put_device(&mdiodev->dev);
+               mdio_device_free(mdiodev);
                return -ENOMEM;
        }
 
@@ -286,10 +286,9 @@ static void dpaa2_pcs_destroy(struct dpaa2_mac *mac)
 
        if (phylink_pcs) {
                struct mdio_device *mdio = lynx_get_mdio_device(phylink_pcs);
-               struct device *dev = &mdio->dev;
 
                lynx_pcs_destroy(phylink_pcs);
-               put_device(dev);
+               mdio_device_free(mdio);
                mac->pcs = NULL;
        }
 }