OSDN Git Service

drm/tegra: Do not reference tegra_plane_funcs directly
authorThierry Reding <treding@nvidia.com>
Thu, 9 Sep 2021 12:08:24 +0000 (14:08 +0200)
committerThierry Reding <treding@nvidia.com>
Thu, 16 Dec 2021 13:07:06 +0000 (14:07 +0100)
Instead of referencing the tegra_plane_funcs struct directly, use each
plane's vtable instead. This makes it more future-proof in case any of
the planes ever use a different set of functions.

Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/gpu/drm/tegra/dc.c

index a29d64f..a73fd6a 100644 (file)
@@ -1267,9 +1267,9 @@ static struct drm_plane *tegra_dc_add_planes(struct drm_device *drm,
                        err = PTR_ERR(planes[i]);
 
                        while (i--)
-                               tegra_plane_funcs.destroy(planes[i]);
+                               planes[i]->funcs->destroy(planes[i]);
 
-                       tegra_plane_funcs.destroy(primary);
+                       primary->funcs->destroy(primary);
                        return ERR_PTR(err);
                }
        }