OSDN Git Service

net: xilinx_ethlite: Fix Rx-pong interrupt
authorPeter Crosthwaite <peter.crosthwaite@xilinx.com>
Tue, 6 May 2014 04:39:38 +0000 (21:39 -0700)
committerStefan Hajnoczi <stefanha@redhat.com>
Mon, 9 Jun 2014 13:38:58 +0000 (15:38 +0200)
There is no CTRL_I bit in the pong buffer control register. The
CTRL_I bit from the ping buffer masks both ping and pong buffers.
Fix.

Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
hw/net/xilinx_ethlite.c

index 5a434f6..1b177b3 100644 (file)
@@ -196,8 +196,9 @@ static ssize_t eth_rx(NetClientState *nc, const uint8_t *buf, size_t size)
     memcpy(&s->regs[rxbase + R_RX_BUF0], buf, size);
 
     s->regs[rxbase + R_RX_CTRL0] |= CTRL_S;
-    if (s->regs[rxbase + R_RX_CTRL0] & CTRL_I)
+    if (s->regs[R_RX_CTRL0] & CTRL_I) {
         eth_pulse_irq(s);
+    }
 
     /* If c_rx_pingpong was set flip buffers.  */
     s->rxbuf ^= s->c_rx_pingpong;