wifi: rtw89: remove superfluous H2C of join_info

We find that when starting WoWLAN, the second join_info H2C is
unnecessary and leads WoWLAN not enter power save mode if using new
firmware, so remove it.

Signed-off-by: Chin-Yen Lee <timlee@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230320093112.30466-2-pkshih@realtek.com

diff --git a/drivers/net/wireless/realtek/rtw89/wow.c b/drivers/net/wireless/realtek/rtw89/wow.c
index c78ee2a..7cff9c1 100644 (file)
--- a/drivers/net/wireless/realtek/rtw89/wow.c
+++ b/drivers/net/wireless/realtek/rtw89/wow.c
@@ -420,14 +420,11 @@ static int rtw89_wow_cfg_wake(struct rtw89_dev *rtwdev, bool wow)
        struct rtw89_vif *rtwvif = (struct rtw89_vif *)wow_vif->drv_priv;
        struct ieee80211_sta *wow_sta;
        struct rtw89_sta *rtwsta = NULL;
-       bool is_conn = true;
        int ret;
 
        wow_sta = ieee80211_find_sta(wow_vif, rtwvif->bssid);
        if (wow_sta)
                rtwsta = (struct rtw89_sta *)wow_sta->drv_priv;
-       else
-               is_conn = false;
 
        if (wow) {
                if (rtw_wow->pattern_cnt)
@@ -454,12 +451,6 @@ static int rtw89_wow_cfg_wake(struct rtw89_dev *rtwdev, bool wow)
                }
        }
 
-       ret = rtw89_fw_h2c_join_info(rtwdev, rtwvif, rtwsta, !is_conn);
-       if (ret) {
-               rtw89_warn(rtwdev, "failed to send h2c join info\n");
-               return ret;
-       }
-
        ret = rtw89_fw_h2c_cam(rtwdev, rtwvif, rtwsta, NULL);
        if (ret) {
                rtw89_warn(rtwdev, "failed to send h2c cam\n");