Last uses of memory_region_clear_global_locking() have been
removed in commit
7070e085d4 ("acpi: mark PMTIMER as unlocked")
and commit
08565552f7 ("cputlb: Move NOTDIRTY handling from I/O
path to TLB path").
Remove memory_region_clear_global_locking() and the now unused
'global_locking' field in MemoryRegion.
Reported-by: Alexander Bulekov <alxndr@bu.edu>
Suggested-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <
20200806150726.962-1-philmd@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
cpu_io_recompile(cpu, retaddr);
}
- if (mr->global_locking && !qemu_mutex_iothread_locked()) {
+ if (!qemu_mutex_iothread_locked()) {
qemu_mutex_lock_iothread();
locked = true;
}
*/
save_iotlb_data(cpu, iotlbentry->addr, section, mr_offset);
- if (mr->global_locking && !qemu_mutex_iothread_locked()) {
+ if (!qemu_mutex_iothread_locked()) {
qemu_mutex_lock_iothread();
locked = true;
}
bool unlocked = !qemu_mutex_iothread_locked();
bool release_lock = false;
- if (unlocked && mr->global_locking) {
+ if (unlocked) {
qemu_mutex_lock_iothread();
unlocked = false;
release_lock = true;
bool nonvolatile;
bool rom_device;
bool flush_coalesced_mmio;
- bool global_locking;
uint8_t dirty_log_mask;
bool is_iommu;
RAMBlock *ram_block;
void memory_region_clear_flush_coalesced(MemoryRegion *mr);
/**
- * memory_region_clear_global_locking: Declares that access processing does
- * not depend on the QEMU global lock.
- *
- * By clearing this property, accesses to the memory region will be processed
- * outside of QEMU's global lock (unless the lock is held on when issuing the
- * access request). In this case, the device model implementing the access
- * handlers is responsible for synchronization of concurrency.
- *
- * @mr: the memory region to be updated.
- */
-void memory_region_clear_global_locking(MemoryRegion *mr);
-
-/**
* memory_region_add_eventfd: Request an eventfd to be triggered when a word
* is written to a location.
*
mr->ops = &unassigned_mem_ops;
mr->enabled = true;
mr->romd_mode = true;
- mr->global_locking = true;
mr->destructor = memory_region_destructor_none;
QTAILQ_INIT(&mr->subregions);
QTAILQ_INIT(&mr->coalesced);
}
}
-void memory_region_clear_global_locking(MemoryRegion *mr)
-{
- mr->global_locking = false;
-}
-
static bool userspace_eventfd_warning;
void memory_region_add_eventfd(MemoryRegion *mr,