OSDN Git Service

mtd: nand: r852: Remove unnecessary synchronize_irq() before free_irq()
authorLars-Peter Clausen <lars@metafoo.de>
Sat, 21 Nov 2015 11:14:44 +0000 (12:14 +0100)
committerBrian Norris <computersforpeace@gmail.com>
Fri, 4 Dec 2015 23:39:08 +0000 (15:39 -0800)
Calling synchronize_irq() right before free_irq() is quite useless. On one
hand the IRQ can easily fire again before free_irq() is entered, on the
other hand free_irq() itself calls synchronize_irq() internally (in a race
condition free way), before any state associated with the IRQ is freed.

Patch was generated using the following semantic patch:
// <smpl>
@@
expression irq;
@@
-synchronize_irq(irq);
 free_irq(irq, ...);
// </smpl>

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
drivers/mtd/nand/r852.c

index d8bb2be..be28cdd 100644 (file)
@@ -980,7 +980,6 @@ static void r852_remove(struct pci_dev *pci_dev)
 
        /* Stop interrupts */
        r852_disable_irqs(dev);
-       synchronize_irq(dev->irq);
        free_irq(dev->irq, dev);
 
        /* Cleanup */