OSDN Git Service

drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 22 Mar 2018 18:21:54 +0000 (13:21 -0500)
committerZhi Wang <zhi.a.wang@intel.com>
Mon, 23 Apr 2018 05:09:35 +0000 (13:09 +0800)
The checks are misleading and not required [1].

[1] https://lkml.org/lkml/2018/3/19/1792

Addresses-Coverity-ID: 1466017
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
drivers/gpu/drm/i915/gvt/scheduler.c

index 1bd7aa0..d1a8fd8 100644 (file)
@@ -97,7 +97,7 @@ static void sr_oa_regs(struct intel_vgpu_workload *workload,
                i915_mmio_reg_offset(EU_PERF_CNTL6),
        };
 
-       if (!workload || !reg_state || workload->ring_id != RCS)
+       if (workload->ring_id != RCS)
                return;
 
        if (save) {