OSDN Git Service

staging: speakup: remove redundant initialization of pointer p_key
authorColin Ian King <colin.king@canonical.com>
Sun, 23 Feb 2020 15:39:54 +0000 (15:39 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 23 Feb 2020 18:22:07 +0000 (19:22 +0100)
Pointer p_key is being initialized with a value that is never read,
it is assigned a new value later on. The initialization is redundant
and can be removed.

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Unused value")
Link: https://lore.kernel.org/r/20200223153954.420731-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/speakup/keyhelp.c

index 5f1bda3..822ceac 100644 (file)
@@ -49,7 +49,7 @@ static int cur_item, nstates;
 static void build_key_data(void)
 {
        u_char *kp, counters[MAXFUNCS], ch, ch1;
-       u_short *p_key = key_data, key;
+       u_short *p_key, key;
        int i, offset = 1;
 
        nstates = (int)(state_tbl[-1]);