OSDN Git Service

net/mlx5e: Avoid warning print when not required
authorSaeed Mahameed <saeedm@mellanox.com>
Fri, 24 May 2019 19:24:43 +0000 (12:24 -0700)
committerSaeed Mahameed <saeedm@mellanox.com>
Mon, 29 Jul 2019 23:40:23 +0000 (16:40 -0700)
When disabling CQE compression in favor of time-stamping, don't show a
warning when CQE compression is already disabled.

Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/en_main.c

index 776eb46..2667832 100644 (file)
@@ -3958,7 +3958,8 @@ int mlx5e_hwstamp_set(struct mlx5e_priv *priv, struct ifreq *ifr)
        case HWTSTAMP_FILTER_PTP_V2_DELAY_REQ:
        case HWTSTAMP_FILTER_NTP_ALL:
                /* Disable CQE compression */
-               netdev_warn(priv->netdev, "Disabling cqe compression");
+               if (MLX5E_GET_PFLAG(&priv->channels.params, MLX5E_PFLAG_RX_CQE_COMPRESS))
+                       netdev_warn(priv->netdev, "Disabling RX cqe compression\n");
                err = mlx5e_modify_rx_cqe_compression_locked(priv, false);
                if (err) {
                        netdev_err(priv->netdev, "Failed disabling cqe compression err=%d\n", err);