OSDN Git Service

[optimizing] trivial x86 explicit null check fix
authorMark Mendell <mark.p.mendell@intel.com>
Tue, 31 Mar 2015 15:34:22 +0000 (11:34 -0400)
committerMark Mendell <mark.p.mendell@intel.com>
Tue, 31 Mar 2015 15:34:22 +0000 (11:34 -0400)
Change a cmp reg,0 to test reg,reg.  I don't know that this code
is even invoked.

Change-Id: Ifddffcb22d8a4060b7abbea17d8e7168535e409b
Signed-off-by: Mark Mendell <mark.p.mendell@intel.com>
compiler/optimizing/code_generator_x86.cc

index 8d0ca0b..0d5fe49 100644 (file)
@@ -3146,7 +3146,7 @@ void InstructionCodeGeneratorX86::GenerateExplicitNullCheck(HNullCheck* instruct
   Location obj = locations->InAt(0);
 
   if (obj.IsRegister()) {
-    __ cmpl(obj.AsRegister<Register>(), Immediate(0));
+    __ testl(obj.AsRegister<Register>(), obj.AsRegister<Register>());
   } else if (obj.IsStackSlot()) {
     __ cmpl(Address(ESP, obj.GetStackIndex()), Immediate(0));
   } else {