OSDN Git Service

net: phy: at803x: mention AR8033 as same as AR8031
authorMichael Walle <michael@walle.cc>
Wed, 6 Nov 2019 22:36:15 +0000 (23:36 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 7 Nov 2019 05:42:06 +0000 (21:42 -0800)
The AR8033 is the AR8031 without PTP support. All other registers are
the same. Unfortunately, they share the same PHY ID. Therefore, we
cannot distinguish between the one with PTP support and the one without.

Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/Kconfig
drivers/net/phy/at803x.c

index 1b884eb..8bccadf 100644 (file)
@@ -442,7 +442,7 @@ config NXP_TJA11XX_PHY
 config AT803X_PHY
        tristate "Qualcomm Atheros AR803X PHYs"
        help
-         Currently supports the AR8030, AR8031 and AR8035 model
+         Currently supports the AR8030, AR8031, AR8033 and AR8035 model
 
 config QSEMI_PHY
        tristate "Quality Semiconductor PHYs"
index aa782b2..716672e 100644 (file)
@@ -93,8 +93,8 @@
 #define AT803X_CLK_OUT_125MHZ_PLL              6
 #define AT803X_CLK_OUT_125MHZ_DSP              7
 
-/* The AR8035 has another mask which is compatible with the AR8031 mask but
- * doesn't support choosing between XTAL/PLL and DSP.
+/* The AR8035 has another mask which is compatible with the AR8031/AR8033 mask
+ * but doesn't support choosing between XTAL/PLL and DSP.
  */
 #define AT8035_CLK_OUT_MASK                    GENMASK(4, 3)
 
@@ -449,7 +449,9 @@ static int at803x_parse_dt(struct phy_device *phydev)
                }
        }
 
-       /* Only supported on AR8031, the AR8030/AR8035 use strapping options */
+       /* Only supported on AR8031/AR8033, the AR8030/AR8035 use strapping
+        * options.
+        */
        if (at803x_match_phy_id(phydev, ATH8031_PHY_ID)) {
                if (of_property_read_bool(node, "qca,keep-pll-enabled"))
                        priv->flags |= AT803X_KEEP_PLL_ENABLED;
@@ -734,9 +736,9 @@ static struct phy_driver at803x_driver[] = {
        .ack_interrupt          = at803x_ack_interrupt,
        .config_intr            = at803x_config_intr,
 }, {
-       /* ATHEROS 8031 */
+       /* ATHEROS 8031/8033 */
        .phy_id                 = ATH8031_PHY_ID,
-       .name                   = "Atheros 8031 ethernet",
+       .name                   = "Atheros 8031/8033 ethernet",
        .phy_id_mask            = AT803X_PHY_ID_MASK,
        .probe                  = at803x_probe,
        .config_init            = at803x_config_init,