OSDN Git Service

PCI: hv: Add missing kfree(hbus) in hv_pci_probe()'s error handling path
authorDexuan Cui <decui@microsoft.com>
Sat, 22 Feb 2020 05:59:57 +0000 (21:59 -0800)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Mon, 24 Feb 2020 11:59:25 +0000 (11:59 +0000)
Now that we use kzalloc() to allocate the hbus buffer, we must call
kfree() in the error path as well to prevent memory leakage.

Fixes: 877b911a5ba0 ("PCI: hv: Avoid a kmemleak false positive caused by the hbus buffer")
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
drivers/pci/controller/pci-hyperv.c

index 0fe0283..15011a3 100644 (file)
@@ -3058,7 +3058,7 @@ destroy_wq:
 free_dom:
        hv_put_dom_num(hbus->sysdata.domain);
 free_bus:
-       free_page((unsigned long)hbus);
+       kfree(hbus);
        return ret;
 }