OSDN Git Service

octeontx2-af: Use GFP_ATOMIC under spin lock
authorWei Yongjun <weiyongjun1@huawei.com>
Thu, 25 Oct 2018 01:42:26 +0000 (01:42 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 25 Oct 2018 18:36:29 +0000 (11:36 -0700)
The function nix_update_mce_list() is called from
nix_update_bcast_mce_list(), and a spin lock is held
here, so we should use GFP_ATOMIC instead.

Fixes: 4b05528ebf0c ("octeontx2-af: Update bcast list upon NIXLF alloc/free")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c

index a4eac3b..a5ab7ef 100644 (file)
@@ -1294,7 +1294,7 @@ static int nix_update_mce_list(struct nix_mce_list *mce_list,
                return 0;
 
        /* Add a new one to the list, at the tail */
-       mce = kzalloc(sizeof(*mce), GFP_KERNEL);
+       mce = kzalloc(sizeof(*mce), GFP_ATOMIC);
        if (!mce)
                return -ENOMEM;
        mce->idx = idx;