OSDN Git Service

iio:adc:lpc32xx Handle return value of clk_prepare_enable
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Tue, 30 May 2017 11:05:27 +0000 (16:35 +0530)
committerJonathan Cameron <jic23@kernel.org>
Sat, 3 Jun 2017 08:55:25 +0000 (09:55 +0100)
clk_prepare_enable() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/adc/lpc32xx_adc.c

index 0de709b..6a5b9a9 100644 (file)
@@ -76,10 +76,14 @@ static int lpc32xx_read_raw(struct iio_dev *indio_dev,
                            long mask)
 {
        struct lpc32xx_adc_state *st = iio_priv(indio_dev);
-
+       int ret;
        if (mask == IIO_CHAN_INFO_RAW) {
                mutex_lock(&indio_dev->mlock);
-               clk_prepare_enable(st->clk);
+               ret = clk_prepare_enable(st->clk);
+               if (ret) {
+                       mutex_unlock(&indio_dev->mlock);
+                       return ret;
+               }
                /* Measurement setup */
                __raw_writel(LPC32XXAD_INTERNAL | (chan->address) |
                             LPC32XXAD_REFp | LPC32XXAD_REFm,