OSDN Git Service

iommu/amd: Call memunmap in error path
authorVasant Hegde <vasant.hegde@amd.com>
Tue, 1 Mar 2022 08:56:23 +0000 (14:26 +0530)
committerJoerg Roedel <jroedel@suse.de>
Tue, 8 Mar 2022 11:18:49 +0000 (12:18 +0100)
Unmap old_devtb in error path.

Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
Link: https://lore.kernel.org/r/20220301085626.87680-3-vasant.hegde@amd.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/amd/init.c

index 6b5af56..f7e7d20 100644 (file)
@@ -980,6 +980,7 @@ static bool copy_device_table(void)
                                get_order(dev_table_size));
        if (old_dev_tbl_cpy == NULL) {
                pr_err("Failed to allocate memory for copying old device table!\n");
+               memunmap(old_devtb);
                return false;
        }
 
@@ -1010,6 +1011,7 @@ static bool copy_device_table(void)
                        if ((int_ctl != DTE_IRQ_REMAP_INTCTL) ||
                            (int_tab_len != DTE_INTTABLEN)) {
                                pr_err("Wrong old irq remapping flag: %#x\n", devid);
+                               memunmap(old_devtb);
                                return false;
                        }