OSDN Git Service
(root)
/
sagit-ice-cold
/
kernel_xiaomi_msm8998.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
c65d235
)
bus: sunxi-rsb: unlock on error in sunxi_rsb_read()
author
Dan Carpenter
<dan.carpenter@oracle.com>
Tue, 3 Nov 2015 22:02:44 +0000
(
01:02
+0300)
committer
Maxime Ripard
<maxime.ripard@free-electrons.com>
Tue, 17 Nov 2015 08:40:49 +0000
(09:40 +0100)
Don't forget to unlock before returning an error code.
Fixes:
d787dcdb9c8f
('bus: sunxi-rsb: Add driver for Allwinner Reduced Serial Bus')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
drivers/bus/sunxi-rsb.c
patch
|
blob
|
history
diff --git
a/drivers/bus/sunxi-rsb.c
b/drivers/bus/sunxi-rsb.c
index
846bc29
..
0cfcb39
100644
(file)
--- a/
drivers/bus/sunxi-rsb.c
+++ b/
drivers/bus/sunxi-rsb.c
@@
-342,13
+342,13
@@
static int sunxi_rsb_read(struct sunxi_rsb *rsb, u8 rtaddr, u8 addr,
ret = _sunxi_rsb_run_xfer(rsb);
if (ret)
- goto
out
;
+ goto
unlock
;
*buf = readl(rsb->regs + RSB_DATA);
+unlock:
mutex_unlock(&rsb->lock);
-out:
return ret;
}