OSDN Git Service

can: mcp251xfd: mcp251xfd_probe(): add missing can_rx_offload_del() in error path
authorMarc Kleine-Budde <mkl@pengutronix.de>
Sun, 2 May 2021 09:34:34 +0000 (11:34 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Thu, 6 May 2021 07:24:06 +0000 (09:24 +0200)
This patch adds the missing can_rx_offload_del(), that must be called
if mcp251xfd_register() fails.

Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN")
Link: https://lore.kernel.org/r/20210504091838.1109047-1-mkl@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c

index f122976..e0ae00e 100644 (file)
@@ -2986,10 +2986,12 @@ static int mcp251xfd_probe(struct spi_device *spi)
 
        err = mcp251xfd_register(priv);
        if (err)
-               goto out_free_candev;
+               goto out_can_rx_offload_del;
 
        return 0;
 
+ out_can_rx_offload_del:
+       can_rx_offload_del(&priv->offload);
  out_free_candev:
        spi->max_speed_hz = priv->spi_max_speed_hz_orig;