OSDN Git Service

drm/bridge: tc358768: Correct BTACNTRL1 programming
authorDmitry Osipenko <digetx@gmail.com>
Sat, 2 Oct 2021 23:34:47 +0000 (02:34 +0300)
committerRobert Foss <robert.foss@linaro.org>
Tue, 19 Oct 2021 09:40:02 +0000 (11:40 +0200)
TXTAGOCNT and RXTASURECNT bitfields of BTACNTRL1 register are swapped in
the code, correct them. Driver doesn't implement low power mode for now,
so this change doesn't make a practical difference yet.

Tested-by: Andreas Westman Dorcsak <hedmoo@yahoo.com> # Asus TF700T
Tested-by: Maxim Schwalm <maxim.schwalm@gmail.com> #TF700T
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20211002233447.1105-6-digetx@gmail.com
drivers/gpu/drm/bridge/tc358768.c

index cfceba5..fd585bf 100644 (file)
@@ -790,7 +790,7 @@ static void tc358768_bridge_pre_enable(struct drm_bridge *bridge)
        val = tc358768_ns_to_cnt(val, dsibclk_nsk) - 1;
        val2 = tc358768_ns_to_cnt(tc358768_to_ns((lptxcnt + 1) * dsibclk_nsk),
                                  dsibclk_nsk) - 2;
-       val |= val2 << 16;
+       val = val << 16 | val2;
        dev_dbg(priv->dev, "BTACNTRL1: 0x%x\n", val);
        tc358768_write(priv, TC358768_BTACNTRL1, val);