OSDN Git Service

ice: remove redundant checks in ice_change_mtu
authorMaciej Fijalkowski <maciej.fijalkowski@intel.com>
Mon, 18 Jan 2021 15:13:13 +0000 (16:13 +0100)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Fri, 12 Feb 2021 18:20:13 +0000 (10:20 -0800)
dev_validate_mtu checks that mtu value specified by user is not less
than min mtu and not greater than max allowed mtu. It is being done
before calling the ndo_change_mtu exposed by driver, so remove these
redundant checks in ice_change_mtu.

Reviewed-by: Björn Töpel <bjorn.topel@intel.com>
Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_main.c

index 813ec6b..2c23c8f 100644 (file)
@@ -6154,15 +6154,6 @@ static int ice_change_mtu(struct net_device *netdev, int new_mtu)
                }
        }
 
-       if (new_mtu < (int)netdev->min_mtu) {
-               netdev_err(netdev, "new MTU invalid. min_mtu is %d\n",
-                          netdev->min_mtu);
-               return -EINVAL;
-       } else if (new_mtu > (int)netdev->max_mtu) {
-               netdev_err(netdev, "new MTU invalid. max_mtu is %d\n",
-                          netdev->min_mtu);
-               return -EINVAL;
-       }
        /* if a reset is in progress, wait for some time for it to complete */
        do {
                if (ice_is_reset_in_progress(pf->state)) {