OSDN Git Service

close file descriptors passed to drop box
authorDoug Zongker <dougz@android.com>
Wed, 25 Nov 2009 17:16:48 +0000 (09:16 -0800)
committerDoug Zongker <dougz@android.com>
Wed, 25 Nov 2009 17:16:48 +0000 (09:16 -0800)
The ParcelFileDescriptors passed to DropBoxManager.addFile() are
supposed to be closed after the call.

services/java/com/android/server/BootReceiver.java

index adbe930..565e50b 100644 (file)
@@ -101,8 +101,9 @@ public class BootReceiver extends BroadcastReceiver {
         long lastTime = Settings.Secure.getLong(cr, setting, 0);
         if (lastTime == fileTime) return;  // Already logged this particular file
 
-        db.addFile(tag,
-                ParcelFileDescriptor.open(file, ParcelFileDescriptor.MODE_READ_ONLY),
-                DropBoxManager.IS_TEXT);
+        ParcelFileDescriptor pfd =
+            ParcelFileDescriptor.open(file, ParcelFileDescriptor.MODE_READ_ONLY);
+        db.addFile(tag, pfd, DropBoxManager.IS_TEXT);
+        pfd.close();
     }
 }