OSDN Git Service

V4L/DVB (6830): cx88-blackbird: remove unnecessary encoder unmute
authorJelle Foks <jelle@foks.8m.com>
Mon, 21 May 2007 17:48:58 +0000 (14:48 -0300)
committerMauro Carvalho Chehab <mchehab@infradead.org>
Fri, 25 Jan 2008 21:03:48 +0000 (19:03 -0200)
Remove the unnecessary BLACKBIRD_UNMUTE calls to the mpeg encoder in
cx88-blackbird.c

The encoder is never muted, hence unmuting should then only be necessary
once after hardware initialization.

I tested this from warm boots and cold boots (with long power down time
to ensure the sram in the chip is emptied), and found that after the
firmware upload the encoder is apparently not muted, making the unmutes
unnecessary.

Signed-off-by: Jelle Foks <jelle@foks.8m.com>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/video/cx88/cx88-blackbird.c

index 4a0e1f8..165c0fd 100644 (file)
@@ -610,9 +610,6 @@ static int blackbird_start_codec(struct file *file, void *priv)
        /* unmute audio source */
        cx_clear(AUD_VOL_CTL, (1 << 6));
 
-       blackbird_api_cmd(dev, CX2341X_ENC_MUTE_VIDEO, 1, 0, BLACKBIRD_UNMUTE);
-       blackbird_api_cmd(dev, CX2341X_ENC_MUTE_AUDIO, 1, 0, BLACKBIRD_UNMUTE);
-
        blackbird_api_cmd(dev, CX2341X_ENC_REFRESH_INPUT, 0,0);
 
        /* initialize the video input */