OSDN Git Service

media: cxd2880-spi: Modified how to declare structure
authorYasunari Takiguchi <Yasunari.Takiguchi@sony.com>
Thu, 26 Apr 2018 06:39:17 +0000 (02:39 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Sat, 5 May 2018 14:37:12 +0000 (10:37 -0400)
This is the modification of structure declaration for spi_transfer.

Signed-off-by: Yasunari Takiguchi <Yasunari.Takiguchi@sony.com>
Signed-off-by: Masayuki Yamamoto <Masayuki.Yamamoto@sony.com>
Signed-off-by: Hideki Nozawa <Hideki.Nozawa@sony.com>
Signed-off-by: Kota Yonezawa <Kota.Yonezawa@sony.com>
Signed-off-by: Toshihiko Matsumoto <Toshihiko.Matsumoto@sony.com>
Signed-off-by: Satoshi Watanabe <Satoshi.C.Watanabe@sony.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/spi/cxd2880-spi.c

index 011a37c..11ce510 100644 (file)
@@ -60,14 +60,13 @@ DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr);
 static int cxd2880_write_spi(struct spi_device *spi, u8 *data, u32 size)
 {
        struct spi_message msg;
-       struct spi_transfer tx;
+       struct spi_transfer tx = {};
 
        if (!spi || !data) {
                pr_err("invalid arg\n");
                return -EINVAL;
        }
 
-       memset(&tx, 0, sizeof(tx));
        tx.tx_buf = data;
        tx.len = size;
 
@@ -120,7 +119,7 @@ static int cxd2880_spi_read_ts(struct spi_device *spi,
        int ret;
        u8 data[3];
        struct spi_message message;
-       struct spi_transfer transfer[2];
+       struct spi_transfer transfer[2] = {};
 
        if (!spi || !read_data || !packet_num) {
                pr_err("invalid arg\n");
@@ -136,7 +135,6 @@ static int cxd2880_spi_read_ts(struct spi_device *spi,
        data[2] = packet_num;
 
        spi_message_init(&message);
-       memset(transfer, 0, sizeof(transfer));
 
        transfer[0].len = 3;
        transfer[0].tx_buf = data;
@@ -373,7 +371,7 @@ static int cxd2880_start_feed(struct dvb_demux_feed *feed)
                        }
                }
                if (i == CXD2880_MAX_FILTER_SIZE) {
-                       pr_err("PID filter is full. Assumed bug.\n");
+                       pr_err("PID filter is full.\n");
                        return -EINVAL;
                }
                if (!dvb_spi->all_pid_feed_count)