OSDN Git Service

Staging: vme: remove an unnecessary and wrong warning message
authorNavy Cheng <navych@126.com>
Thu, 6 Aug 2015 01:47:57 +0000 (09:47 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 Aug 2015 22:10:58 +0000 (15:10 -0700)
The wrong warning message in vme_user_probe() will mislead developers and
users. As the error message which prompt cdev_add() error already exists,
just remove the unnecessary and wrong message.

Signed-off-by: Navy Cheng <navych@126.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vme/devices/vme_user.c

index b3e3c2d..8e61a3b 100644 (file)
@@ -561,10 +561,8 @@ static int vme_user_probe(struct vme_dev *vdev)
        vme_user_cdev->ops = &vme_user_fops;
        vme_user_cdev->owner = THIS_MODULE;
        err = cdev_add(vme_user_cdev, MKDEV(VME_MAJOR, 0), VME_DEVS);
-       if (err) {
-               dev_warn(&vdev->dev, "cdev_all failed\n");
+       if (err)
                goto err_char;
-       }
 
        /* Request slave resources and allocate buffers (128kB wide) */
        for (i = SLAVE_MINOR; i < (SLAVE_MAX + 1); i++) {