OSDN Git Service

iio: as3935: Remove no-op trigger ops
authorLars-Peter Clausen <lars@metafoo.de>
Sun, 31 Oct 2021 14:21:27 +0000 (15:21 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Wed, 17 Nov 2021 17:51:37 +0000 (17:51 +0000)
The IIO core handles a trigger ops with all NULL callbacks the
same as if the trigger ops itself was NULL.

Remove the empty trigger ops from the interrupt trigger driver to slightly
reduce the boilerplate code. Object size of the driver module is also
slightly reduced.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20211031142130.20791-6-lars@metafoo.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/proximity/as3935.c

index 3797a8f..d62766b 100644 (file)
@@ -238,9 +238,6 @@ err_read:
        return IRQ_HANDLED;
 }
 
-static const struct iio_trigger_ops iio_interrupt_trigger_ops = {
-};
-
 static void as3935_event_work(struct work_struct *work)
 {
        struct as3935_state *st;
@@ -417,7 +414,6 @@ static int as3935_probe(struct spi_device *spi)
        st->trig = trig;
        st->noise_tripped = jiffies - HZ;
        iio_trigger_set_drvdata(trig, indio_dev);
-       trig->ops = &iio_interrupt_trigger_ops;
 
        ret = devm_iio_trigger_register(dev, trig);
        if (ret) {