OSDN Git Service

block: fix boolreturn.cocci warning
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Fri, 28 Jan 2022 04:34:54 +0000 (12:34 +0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 2 Feb 2022 14:50:00 +0000 (07:50 -0700)
Return statements in functions returning bool should use true/false
instead of 1/0.

./block/bio.c:1081:9-10: WARNING: return of 0/1 in function
'bio_add_folio' with return type bool.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Link: https://lore.kernel.org/r/20220128043454.68927-1-jiapeng.chong@linux.alibaba.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bio.c

index 03cefe8..2e19ca6 100644 (file)
@@ -1078,7 +1078,7 @@ bool bio_add_folio(struct bio *bio, struct folio *folio, size_t len,
                   size_t off)
 {
        if (len > UINT_MAX || off > UINT_MAX)
-               return 0;
+               return false;
        return bio_add_page(bio, &folio->page, len, off) > 0;
 }