OSDN Git Service
(root)
/
uclinux-h8
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
88e1419
)
spi: spi-ti-qspi: fix reference leak in ti_qspi_setup
author
Zhang Qilong
<zhangqilong3@huawei.com>
Tue, 3 Nov 2020 14:09:47 +0000
(22:09 +0800)
committer
Mark Brown
<broonie@kernel.org>
Mon, 9 Nov 2020 19:44:26 +0000
(19:44 +0000)
pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in ti_qspi_setup, so we should fix it.
Fixes:
505a14954e2d7
("spi/qspi: Add qspi flash controller")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link:
https://lore.kernel.org/r/20201103140947.3815-1-zhangqilong3@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-ti-qspi.c
patch
|
blob
|
history
diff --git
a/drivers/spi/spi-ti-qspi.c
b/drivers/spi/spi-ti-qspi.c
index
3c41649
..
9417385
100644
(file)
--- a/
drivers/spi/spi-ti-qspi.c
+++ b/
drivers/spi/spi-ti-qspi.c
@@
-174,6
+174,7
@@
static int ti_qspi_setup(struct spi_device *spi)
ret = pm_runtime_get_sync(qspi->dev);
if (ret < 0) {
+ pm_runtime_put_noidle(qspi->dev);
dev_err(qspi->dev, "pm_runtime_get_sync() failed\n");
return ret;
}