OSDN Git Service

gpio: gpio-xilinx: Simplify with dev_err_probe()
authorSrinivas Neeli <srinivas.neeli@xilinx.com>
Fri, 29 Jan 2021 14:26:46 +0000 (19:56 +0530)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Mon, 15 Feb 2021 10:43:33 +0000 (11:43 +0100)
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.

Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-xilinx.c

index be53938..d010a63 100644 (file)
@@ -357,11 +357,8 @@ static int xgpio_probe(struct platform_device *pdev)
        }
 
        chip->clk = devm_clk_get_optional(&pdev->dev, NULL);
-       if (IS_ERR(chip->clk)) {
-               if (PTR_ERR(chip->clk) != -EPROBE_DEFER)
-                       dev_dbg(&pdev->dev, "Input clock not found\n");
-               return PTR_ERR(chip->clk);
-       }
+       if (IS_ERR(chip->clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(chip->clk), "input clock not found.\n");
 
        status = clk_prepare_enable(chip->clk);
        if (status < 0) {