OSDN Git Service

scsi: lpfc: Drop lpfc_no_handler()
authorHannes Reinecke <hare@suse.de>
Tue, 1 Mar 2022 14:37:15 +0000 (15:37 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 2 Mar 2022 04:56:29 +0000 (23:56 -0500)
The default SCSI EH action for a non-existing EH callback is to return
FAILED, so having a callback just returning FAILED is pointless.

Link: https://lore.kernel.org/r/20220301143718.40913-3-hare@suse.de
Cc: James Smart <james.smart@broadcom.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_scsi.c

index a061b4e..943f7e8 100644 (file)
@@ -7094,12 +7094,6 @@ lpfc_no_command(struct Scsi_Host *shost, struct scsi_cmnd *cmnd)
 }
 
 static int
-lpfc_no_handler(struct scsi_cmnd *cmnd)
-{
-       return FAILED;
-}
-
-static int
 lpfc_no_slave(struct scsi_device *sdev)
 {
        return -ENODEV;
@@ -7111,10 +7105,6 @@ struct scsi_host_template lpfc_template_nvme = {
        .proc_name              = LPFC_DRIVER_NAME,
        .info                   = lpfc_info,
        .queuecommand           = lpfc_no_command,
-       .eh_abort_handler       = lpfc_no_handler,
-       .eh_device_reset_handler = lpfc_no_handler,
-       .eh_target_reset_handler = lpfc_no_handler,
-       .eh_host_reset_handler  = lpfc_no_handler,
        .slave_alloc            = lpfc_no_slave,
        .slave_configure        = lpfc_no_slave,
        .scan_finished          = lpfc_scan_finished,