btrfs: convert logic BUG_ON()'s in replace_path to ASSERT()'s

[ Upstream commit 7a9213a93546e7eaef90e6e153af6b8fc7553f10 ]

A few BUG_ON()'s in replace_path are purely to keep us from making
logical mistakes, so replace them with ASSERT()'s.

Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
index e6e4e6f..06c6a66 100644 (file)
--- a/fs/btrfs/relocation.c
+++ b/fs/btrfs/relocation.c
@@ -1755,8 +1755,8 @@ int replace_path(struct btrfs_trans_handle *trans,
        int ret;
        int slot;
 
-       BUG_ON(src->root_key.objectid != BTRFS_TREE_RELOC_OBJECTID);
-       BUG_ON(dest->root_key.objectid == BTRFS_TREE_RELOC_OBJECTID);
+       ASSERT(src->root_key.objectid == BTRFS_TREE_RELOC_OBJECTID);
+       ASSERT(dest->root_key.objectid != BTRFS_TREE_RELOC_OBJECTID);
 
        last_snapshot = btrfs_root_last_snapshot(&src->root_item);
 again:
@@ -1790,7 +1790,7 @@ again:
                struct btrfs_key first_key;
 
                level = btrfs_header_level(parent);
-               BUG_ON(level < lowest_level);
+               ASSERT(level >= lowest_level);
 
                ret = btrfs_bin_search(parent, &key, level, &slot);
                if (ret && slot > 0)