OSDN Git Service

media: dvb: Add check on sp8870_readreg
authorAditya Pakki <pakki001@umn.edu>
Thu, 27 Dec 2018 18:58:01 +0000 (13:58 -0500)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Wed, 16 Jan 2019 16:45:33 +0000 (11:45 -0500)
In sp8870_set_frontend_parameters, the function sp8870_readreg
may return an error when i2c_transfer fails. The fix checks for
this error and returns upstream consistent with other invocations.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/dvb-frontends/sp8870.c

index 8d31cf3..270a3c5 100644 (file)
@@ -293,7 +293,9 @@ static int sp8870_set_frontend_parameters(struct dvb_frontend *fe)
        sp8870_writereg(state, 0xc05, reg0xc05);
 
        // read status reg in order to clear pending irqs
-       sp8870_readreg(state, 0x200);
+       err = sp8870_readreg(state, 0x200);
+       if (err)
+               return err;
 
        // system controller start
        sp8870_microcontroller_start(state);