OSDN Git Service

ASoC: amd: vg: fix signedness bug in acp5x_audio_probe()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 4 Mar 2022 13:12:56 +0000 (16:12 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 7 Mar 2022 15:45:56 +0000 (15:45 +0000)
The "adata->i2s_irq" variable is unsigned so the error handling
will not work.

Fixes: 87d71a128771 ("ASoC: amd: pcm-dma: Use platform_get_irq() to get the interrupt")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20220304131256.GA28739@kili
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/vangogh/acp5x-pcm-dma.c

index e4e6685..31fa166 100644 (file)
@@ -388,9 +388,10 @@ static int acp5x_audio_probe(struct platform_device *pdev)
        if (!adata->acp5x_base)
                return -ENOMEM;
 
-       adata->i2s_irq = platform_get_irq(pdev, 0);
-       if (adata->i2s_irq < 0)
-               return -ENODEV;
+       status = platform_get_irq(pdev, 0);
+       if (status < 0)
+               return status;
+       adata->i2s_irq = status;
 
        dev_set_drvdata(&pdev->dev, adata);
        status = devm_snd_soc_register_component(&pdev->dev,