OSDN Git Service

mlxsw: spectrum_acl_bloom_filter: Reorder functions to make the code more aesthetic
authorAmit Cohen <amcohen@nvidia.com>
Thu, 6 Jan 2022 16:06:47 +0000 (18:06 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 7 Jan 2022 04:00:44 +0000 (20:00 -0800)
Currently, mlxsw_sp_acl_bf_rule_count_index_get() is implemented before
mlxsw_sp_acl_bf_index_get() but is used after it.

Adding a new function for Spectrum-4 would make them further apart still.
Fix by moving them around.

Signed-off-by: Amit Cohen <amcohen@nvidia.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_bloom_filter.c

index dbd3beb..732c261 100644 (file)
@@ -143,14 +143,6 @@ mlxsw_sp_acl_bf_key_encode(struct mlxsw_sp_acl_atcam_region *aregion,
 }
 
 static unsigned int
-mlxsw_sp_acl_bf_rule_count_index_get(struct mlxsw_sp_acl_bf *bf,
-                                    unsigned int erp_bank,
-                                    unsigned int bf_index)
-{
-       return erp_bank * bf->bank_size + bf_index;
-}
-
-static unsigned int
 mlxsw_sp_acl_bf_index_get(struct mlxsw_sp_acl_bf *bf,
                          struct mlxsw_sp_acl_atcam_region *aregion,
                          struct mlxsw_sp_acl_atcam_entry *aentry)
@@ -162,6 +154,14 @@ mlxsw_sp_acl_bf_index_get(struct mlxsw_sp_acl_bf *bf,
        return mlxsw_sp_acl_bf_crc(bf_key, bf_size);
 }
 
+static unsigned int
+mlxsw_sp_acl_bf_rule_count_index_get(struct mlxsw_sp_acl_bf *bf,
+                                    unsigned int erp_bank,
+                                    unsigned int bf_index)
+{
+       return erp_bank * bf->bank_size + bf_index;
+}
+
 int
 mlxsw_sp_acl_bf_entry_add(struct mlxsw_sp *mlxsw_sp,
                          struct mlxsw_sp_acl_bf *bf,