OSDN Git Service

block/bsg-lib: use PTR_ERR_OR_ZERO to simplify the flow path
authorzhong jiang <zhongjiang@huawei.com>
Tue, 31 Jul 2018 16:13:14 +0000 (00:13 +0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 1 Aug 2018 15:13:03 +0000 (09:13 -0600)
Simplify the code by using the PTR_ERR_OR_ZERO, instead of the
open code. It is better.

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bsg-lib.c

index 9419def..f3501cd 100644 (file)
@@ -48,9 +48,8 @@ static int bsg_transport_fill_hdr(struct request *rq, struct sg_io_v4 *hdr,
 
        job->request_len = hdr->request_len;
        job->request = memdup_user(uptr64(hdr->request), hdr->request_len);
-       if (IS_ERR(job->request))
-               return PTR_ERR(job->request);
-       return 0;
+
+       return PTR_ERR_OR_ZERO(job->request);
 }
 
 static int bsg_transport_complete_rq(struct request *rq, struct sg_io_v4 *hdr)