OSDN Git Service

spi-atmel: support inter-word delay
authorJonas Bonn <jonas@norrbonn.se>
Wed, 30 Jan 2019 08:40:05 +0000 (09:40 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 30 Jan 2019 23:02:11 +0000 (23:02 +0000)
If the SPI slave requires an inter-word delay, configure the DLYBCT
register accordingly.

Tested on a SAMA5D2 board (derived from SAMA5D2-Xplained reference
board).

Signed-off-by: Jonas Bonn <jonas@norrbonn.se>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
CC: Nicolas Ferre <nicolas.ferre@microchip.com>
CC: Mark Brown <broonie@kernel.org>
CC: Alexandre Belloni <alexandre.belloni@bootlin.com>
CC: Ludovic Desroches <ludovic.desroches@microchip.com>
CC: linux-spi@vger.kernel.org
CC: linux-arm-kernel@lists.infradead.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-atmel.c

index f53f0c5..4954f0a 100644 (file)
@@ -1201,13 +1201,14 @@ static int atmel_spi_setup(struct spi_device *spi)
                csr |= SPI_BIT(CSAAT);
 
        /* DLYBS is mostly irrelevant since we manage chipselect using GPIOs.
-        *
-        * DLYBCT would add delays between words, slowing down transfers.
-        * It could potentially be useful to cope with DMA bottlenecks, but
-        * in those cases it's probably best to just use a lower bitrate.
         */
        csr |= SPI_BF(DLYBS, 0);
-       csr |= SPI_BF(DLYBCT, 0);
+
+       /* DLYBCT adds delays between words.  This is useful for slow devices
+        * that need a bit of time to setup the next transfer.
+        */
+       csr |= SPI_BF(DLYBCT,
+                       (as->spi_clk / 1000000 * spi->word_delay_usecs) >> 5);
 
        asd = spi->controller_state;
        if (!asd) {