OSDN Git Service

spi: spi-qcom-qspi: Fix remaining driver nits
authorRyan Case <ryandcase@chromium.org>
Tue, 23 Oct 2018 01:07:07 +0000 (18:07 -0700)
committerMark Brown <broonie@kernel.org>
Thu, 22 Nov 2018 14:38:13 +0000 (14:38 +0000)
Address remaining comments from original driver patch series

* Move RD_FIFO_CFG to be ordered corretly
* Expand spinlock comment

Signed-off-by: Ryan Case <ryandcase@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-qcom-qspi.c

index b8163b4..e0f0611 100644 (file)
@@ -90,6 +90,9 @@
 #define PIO_DATAOUT_1B         0x0020
 #define PIO_DATAOUT_4B         0x0024
 
+#define RD_FIFO_CFG            0x0028
+#define CONTINUOUS_MODE                BIT(0)
+
 #define RD_FIFO_STATUS 0x002c
 #define FIFO_EMPTY     BIT(11)
 #define WR_CNTS_MSK    0x7f0
 #define RDY_16BYTE     BIT(1)
 #define FIFO_RDY       BIT(0)
 
-#define RD_FIFO_CFG            0x0028
-#define CONTINUOUS_MODE                BIT(0)
-
 #define RD_FIFO_RESET          0x0030
 #define RESET_FIFO             BIT(0)
 
@@ -139,7 +139,7 @@ struct qcom_qspi {
        struct device *dev;
        struct clk_bulk_data clks[QSPI_NUM_CLKS];
        struct qspi_xfer xfer;
-       /* Lock to protect data accessed by IRQs */
+       /* Lock to protect xfer and IRQ accessed registers */
        spinlock_t lock;
 };