OSDN Git Service

staging: comedi: ni_660x: fix missing break in switch statement
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 12 Feb 2019 18:44:50 +0000 (12:44 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Feb 2019 18:43:34 +0000 (19:43 +0100)
Add missing break statement in order to prevent the code from falling
through to the default case and return -EINVAL every time.

This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.

Fixes: aa94f2888825 ("staging: comedi: ni_660x: tidy up ni_660x_set_pfi_routing()")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/ni_660x.c

index e70a461..405573e 100644 (file)
@@ -656,6 +656,7 @@ static int ni_660x_set_pfi_routing(struct comedi_device *dev,
        case NI_660X_PFI_OUTPUT_DIO:
                if (chan > 31)
                        return -EINVAL;
+               break;
        default:
                return -EINVAL;
        }