OSDN Git Service

net: hns: hnae: remove unnecessary __module_get() and module_put()
authorYang Yingliang <yangyingliang@huawei.com>
Fri, 28 Oct 2022 07:34:57 +0000 (15:34 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 31 Oct 2022 09:18:14 +0000 (09:18 +0000)
hnae_ae_register() is called from hns_dsaf_probe(), the refcount of
module hnae has already be got in resolve_symbol() while calling the
function, so the __module_get()/module_put() can be removed.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns/hnae.c

index 430ecce..9b26f0f 100644 (file)
@@ -424,8 +424,6 @@ int hnae_ae_register(struct hnae_ae_dev *hdev, struct module *owner)
                return ret;
        }
 
-       __module_get(THIS_MODULE);
-
        INIT_LIST_HEAD(&hdev->handle_list);
        spin_lock_init(&hdev->lock);
 
@@ -445,7 +443,6 @@ EXPORT_SYMBOL(hnae_ae_register);
 void hnae_ae_unregister(struct hnae_ae_dev *hdev)
 {
        device_unregister(&hdev->cls_dev);
-       module_put(THIS_MODULE);
 }
 EXPORT_SYMBOL(hnae_ae_unregister);