OSDN Git Service

drm/bridge: vga-dac: clean up drm_bridge_add call
authorInki Dae <inki.dae@samsung.com>
Mon, 3 Jul 2017 08:42:20 +0000 (17:42 +0900)
committerArchit Taneja <architt@codeaurora.org>
Thu, 6 Jul 2017 08:46:15 +0000 (14:16 +0530)
This patch removes unnecessary checking of return value.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
Signed-off-by: Archit Taneja <architt@codeaurora.org>
Link: http://patchwork.freedesktop.org/patch/msgid/1499071350-25168-5-git-send-email-inki.dae@samsung.com
drivers/gpu/drm/bridge/dumb-vga-dac.c

index 831a606..8a52539 100644 (file)
@@ -177,7 +177,6 @@ static struct i2c_adapter *dumb_vga_retrieve_ddc(struct device *dev)
 static int dumb_vga_probe(struct platform_device *pdev)
 {
        struct dumb_vga *vga;
-       int ret;
 
        vga = devm_kzalloc(&pdev->dev, sizeof(*vga), GFP_KERNEL);
        if (!vga)
@@ -186,7 +185,7 @@ static int dumb_vga_probe(struct platform_device *pdev)
 
        vga->vdd = devm_regulator_get_optional(&pdev->dev, "vdd");
        if (IS_ERR(vga->vdd)) {
-               ret = PTR_ERR(vga->vdd);
+               int ret = PTR_ERR(vga->vdd);
                if (ret == -EPROBE_DEFER)
                        return -EPROBE_DEFER;
                vga->vdd = NULL;
@@ -207,11 +206,9 @@ static int dumb_vga_probe(struct platform_device *pdev)
        vga->bridge.funcs = &dumb_vga_bridge_funcs;
        vga->bridge.of_node = pdev->dev.of_node;
 
-       ret = drm_bridge_add(&vga->bridge);
-       if (ret && !IS_ERR(vga->ddc))
-               i2c_put_adapter(vga->ddc);
+       drm_bridge_add(&vga->bridge);
 
-       return ret;
+       return 0;
 }
 
 static int dumb_vga_remove(struct platform_device *pdev)