OSDN Git Service

ipv6: addrconf: do not block BH in ipv6_chk_addr_and_flags()
authorEric Dumazet <edumazet@google.com>
Mon, 23 Oct 2017 23:17:48 +0000 (16:17 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 24 Oct 2017 08:54:19 +0000 (17:54 +0900)
rcu_read_lock() is enough here, as inet6_ifa_finish_destroy()
uses kfree_rcu()

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/addrconf.c

index d70d981..a6cf37b 100644 (file)
@@ -1844,7 +1844,7 @@ int ipv6_chk_addr_and_flags(struct net *net, const struct in6_addr *addr,
        struct inet6_ifaddr *ifp;
        u32 ifp_flags;
 
-       rcu_read_lock_bh();
+       rcu_read_lock();
        hlist_for_each_entry_rcu(ifp, &inet6_addr_lst[hash], addr_lst) {
                if (!net_eq(dev_net(ifp->idev->dev), net))
                        continue;
@@ -1858,12 +1858,12 @@ int ipv6_chk_addr_and_flags(struct net *net, const struct in6_addr *addr,
                    !(ifp_flags&banned_flags) &&
                    (!dev || ifp->idev->dev == dev ||
                     !(ifp->scope&(IFA_LINK|IFA_HOST) || strict))) {
-                       rcu_read_unlock_bh();
+                       rcu_read_unlock();
                        return 1;
                }
        }
 
-       rcu_read_unlock_bh();
+       rcu_read_unlock();
        return 0;
 }
 EXPORT_SYMBOL(ipv6_chk_addr_and_flags);