OSDN Git Service

wifi: rtw88: fix memory leak in rtw_usb_probe()
authorDongliang Mu <dzm91@hust.edu.cn>
Thu, 9 Mar 2023 02:16:36 +0000 (10:16 +0800)
committerKalle Valo <kvalo@kernel.org>
Mon, 13 Mar 2023 13:45:30 +0000 (15:45 +0200)
drivers/net/wireless/realtek/rtw88/usb.c:876 rtw_usb_probe()
warn: 'hw' from ieee80211_alloc_hw() not released on lines: 811

Fix this by modifying return to a goto statement.

Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230309021636.528601-1-dzm91@hust.edu.cn
drivers/net/wireless/realtek/rtw88/usb.c

index 2a8336b..68e1b78 100644 (file)
@@ -808,7 +808,7 @@ int rtw_usb_probe(struct usb_interface *intf, const struct usb_device_id *id)
 
        ret = rtw_usb_alloc_rx_bufs(rtwusb);
        if (ret)
-               return ret;
+               goto err_release_hw;
 
        ret = rtw_core_init(rtwdev);
        if (ret)