OSDN Git Service

drm/rockchip/dsi: fix handling mipi_dsi_pixel_format_to_bpp result
authorAndrzej Hajda <a.hajda@samsung.com>
Thu, 14 Jan 2016 08:59:02 +0000 (09:59 +0100)
committerMark Yao <mark.yao@rock-chips.com>
Mon, 18 Jan 2016 00:43:16 +0000 (08:43 +0800)
The function can return negative value so it should be assigned to signed
variable.

The problem has been detected using patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Reviewed-by: Chris Zhong <zyw@rock-chips.com>
drivers/gpu/drm/rockchip/dw-mipi-dsi.c

index 7bfe243..f8f8f29 100644 (file)
@@ -461,10 +461,11 @@ static int dw_mipi_dsi_phy_init(struct dw_mipi_dsi *dsi)
 
 static int dw_mipi_dsi_get_lane_bps(struct dw_mipi_dsi *dsi)
 {
-       unsigned int bpp, i, pre;
+       unsigned int i, pre;
        unsigned long mpclk, pllref, tmp;
        unsigned int m = 1, n = 1, target_mbps = 1000;
        unsigned int max_mbps = dptdin_map[ARRAY_SIZE(dptdin_map) - 1].max_mbps;
+       int bpp;
 
        bpp = mipi_dsi_pixel_format_to_bpp(dsi->format);
        if (bpp < 0) {