OSDN Git Service

net: ks8851-ml: use devm_platform_ioremap_resource() to simplify code
authorYueHaibing <yuehaibing@huawei.com>
Wed, 21 Aug 2019 12:58:11 +0000 (20:58 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 21 Aug 2019 20:42:12 +0000 (13:42 -0700)
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/micrel/ks8851_mll.c

index e52b015..a41a90c 100644 (file)
@@ -1225,7 +1225,6 @@ MODULE_DEVICE_TABLE(of, ks8851_ml_dt_ids);
 static int ks8851_probe(struct platform_device *pdev)
 {
        int err;
-       struct resource *io_d, *io_c;
        struct net_device *netdev;
        struct ks_net *ks;
        u16 id, data;
@@ -1240,15 +1239,13 @@ static int ks8851_probe(struct platform_device *pdev)
        ks = netdev_priv(netdev);
        ks->netdev = netdev;
 
-       io_d = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       ks->hw_addr = devm_ioremap_resource(&pdev->dev, io_d);
+       ks->hw_addr = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(ks->hw_addr)) {
                err = PTR_ERR(ks->hw_addr);
                goto err_free;
        }
 
-       io_c = platform_get_resource(pdev, IORESOURCE_MEM, 1);
-       ks->hw_addr_cmd = devm_ioremap_resource(&pdev->dev, io_c);
+       ks->hw_addr_cmd = devm_platform_ioremap_resource(pdev, 1);
        if (IS_ERR(ks->hw_addr_cmd)) {
                err = PTR_ERR(ks->hw_addr_cmd);
                goto err_free;