OSDN Git Service

wifi: ath12k: Add missing unwind goto in ath12k_pci_probe()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Tue, 7 Mar 2023 10:47:06 +0000 (02:47 -0800)
committerKalle Valo <quic_kvalo@quicinc.com>
Wed, 15 Mar 2023 10:18:22 +0000 (12:18 +0200)
Smatch Warns:
drivers/net/wireless/ath/ath12k/pci.c:1198 ath12k_pci_probe()
warn: missing unwind goto?

Store the error value in ret and use correct label with a goto.

Only Compile tested, found with Smatch.

Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/all/Y+426q6cfkEdb5Bv@kili/
Suggested-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230307104706.240119-1-harshit.m.mogalapalli@oracle.com
drivers/net/wireless/ath/ath12k/pci.c

index d32637b..00b0080 100644 (file)
@@ -1223,7 +1223,8 @@ static int ath12k_pci_probe(struct pci_dev *pdev,
                        dev_err(&pdev->dev,
                                "Unknown hardware version found for QCN9274: 0x%x\n",
                                soc_hw_version_major);
-                       return -EOPNOTSUPP;
+                       ret = -EOPNOTSUPP;
+                       goto err_pci_free_region;
                }
                break;
        case WCN7850_DEVICE_ID: