OSDN Git Service

sctp: use SCTP_FUTURE_ASSOC for SCTP_LOCAL_AUTH_CHUNKS sockopt
authorXin Long <lucien.xin@gmail.com>
Mon, 28 Jan 2019 07:08:28 +0000 (15:08 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 30 Jan 2019 08:44:06 +0000 (00:44 -0800)
Check with SCTP_FUTURE_ASSOC instead in
sctp_getsockopt_local_auth_chunks, it's compatible with 0.

Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/socket.c

index f38c912..7df2123 100644 (file)
@@ -6767,14 +6767,12 @@ static int sctp_getsockopt_local_auth_chunks(struct sock *sk, int len,
 
        to = p->gauth_chunks;
        asoc = sctp_id2assoc(sk, val.gauth_assoc_id);
-       if (!asoc && val.gauth_assoc_id && sctp_style(sk, UDP))
+       if (!asoc && val.gauth_assoc_id != SCTP_FUTURE_ASSOC &&
+           sctp_style(sk, UDP))
                return -EINVAL;
 
-       if (asoc)
-               ch = (struct sctp_chunks_param *)asoc->c.auth_chunks;
-       else
-               ch = ep->auth_chunk_list;
-
+       ch = asoc ? (struct sctp_chunks_param *)asoc->c.auth_chunks
+                 : ep->auth_chunk_list;
        if (!ch)
                goto num;