OSDN Git Service

neighbour: Remove redundant initialization of 'bucket'
authorYang Li <yang.lee@linux.alibaba.com>
Sat, 8 May 2021 10:03:05 +0000 (18:03 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 10 May 2021 21:25:13 +0000 (14:25 -0700)
Integer variable 'bucket' is being initialized however
this value is never read as 'bucket' is assigned zero
in for statement. Remove the redundant assignment.

Cleans up clang warning:

net/core/neighbour.c:3144:6: warning: Value stored to 'bucket' during
its initialization is never read [clang-analyzer-deadcode.DeadStores]

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/neighbour.c

index 98f20ef..2b2f333 100644 (file)
@@ -3141,7 +3141,7 @@ static struct pneigh_entry *pneigh_get_first(struct seq_file *seq)
        struct net *net = seq_file_net(seq);
        struct neigh_table *tbl = state->tbl;
        struct pneigh_entry *pn = NULL;
-       int bucket = state->bucket;
+       int bucket;
 
        state->flags |= NEIGH_SEQ_IS_PNEIGH;
        for (bucket = 0; bucket <= PNEIGH_HASHMASK; bucket++) {