OSDN Git Service

drm/i915: Use kcalloc instead of kzalloc to allocate array
authorThomas Meyer <thomas@m3y3r.de>
Tue, 29 Nov 2011 21:08:00 +0000 (22:08 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 17 Jan 2012 16:33:24 +0000 (17:33 +0100)
The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_bios.c

index 63880e2..5065633 100644 (file)
@@ -572,7 +572,7 @@ parse_device_mapping(struct drm_i915_private *dev_priv,
                DRM_DEBUG_KMS("no child dev is parsed from VBT\n");
                return;
        }
-       dev_priv->child_dev = kzalloc(sizeof(*p_child) * count, GFP_KERNEL);
+       dev_priv->child_dev = kcalloc(count, sizeof(*p_child), GFP_KERNEL);
        if (!dev_priv->child_dev) {
                DRM_DEBUG_KMS("No memory space for child device\n");
                return;