OSDN Git Service

iio: dac: stm32-dac: use reset controller only at probe time
authorEtienne Carriere <etienne.carriere@st.com>
Mon, 13 Jan 2020 13:14:25 +0000 (14:14 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 18 Jan 2020 14:30:15 +0000 (14:30 +0000)
This change removes the reset controller reference from the local
DAC instance since it is used only at probe time.

Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/dac/stm32-dac-core.c

index 9e6b4cd..4d93446 100644 (file)
 /**
  * struct stm32_dac_priv - stm32 DAC core private data
  * @pclk:              peripheral clock common for all DACs
- * @rst:               peripheral reset control
  * @vref:              regulator reference
  * @common:            Common data for all DAC instances
  */
 struct stm32_dac_priv {
        struct clk *pclk;
-       struct reset_control *rst;
        struct regulator *vref;
        struct stm32_dac_common common;
 };
@@ -94,6 +92,7 @@ static int stm32_dac_probe(struct platform_device *pdev)
        struct regmap *regmap;
        struct resource *res;
        void __iomem *mmio;
+       struct reset_control *rst;
        int ret;
 
        if (!dev->of_node)
@@ -148,11 +147,11 @@ static int stm32_dac_probe(struct platform_device *pdev)
        priv->common.vref_mv = ret / 1000;
        dev_dbg(dev, "vref+=%dmV\n", priv->common.vref_mv);
 
-       priv->rst = devm_reset_control_get_exclusive(dev, NULL);
-       if (!IS_ERR(priv->rst)) {
-               reset_control_assert(priv->rst);
+       rst = devm_reset_control_get_exclusive(dev, NULL);
+       if (!IS_ERR(rst)) {
+               reset_control_assert(rst);
                udelay(2);
-               reset_control_deassert(priv->rst);
+               reset_control_deassert(rst);
        }
 
        if (cfg && cfg->has_hfsel) {