OSDN Git Service

spi: hisi-sfc-v3xx: drop unnecessary ACPI_PTR and related ifendif protection
authorYicong Yang <yangyicong@hisilicon.com>
Mon, 12 Apr 2021 11:58:28 +0000 (19:58 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 12 Apr 2021 16:07:38 +0000 (17:07 +0100)
We use ACPI_PTR() and related ifendif protection for the id table.
This is unnecessary as the struct acpi_device_id is defined in
mod_devicetable.h and doesn't rely on ACPI. The driver doesn't
use any ACPI apis, so it can be compiled in the ACPI=n case
with no warnings.

So remove the ACPI_PTR and related ifendif protection, also
replace the header acpi.h with mod_devicetable.h.

Acked-by: John Garry <john.garry@huawei.com>
Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Link: https://lore.kernel.org/r/1618228708-37949-3-git-send-email-yangyicong@hisilicon.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-hisi-sfc-v3xx.c

index 0d9e103..d3a23b1 100644 (file)
@@ -5,13 +5,13 @@
 // Copyright (c) 2019 HiSilicon Technologies Co., Ltd.
 // Author: John Garry <john.garry@huawei.com>
 
-#include <linux/acpi.h>
 #include <linux/bitops.h>
 #include <linux/completion.h>
 #include <linux/dmi.h>
 #include <linux/interrupt.h>
 #include <linux/iopoll.h>
 #include <linux/module.h>
+#include <linux/mod_devicetable.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/spi/spi.h>
@@ -508,18 +508,16 @@ err_put_master:
        return ret;
 }
 
-#if IS_ENABLED(CONFIG_ACPI)
 static const struct acpi_device_id hisi_sfc_v3xx_acpi_ids[] = {
        {"HISI0341", 0},
        {}
 };
 MODULE_DEVICE_TABLE(acpi, hisi_sfc_v3xx_acpi_ids);
-#endif
 
 static struct platform_driver hisi_sfc_v3xx_spi_driver = {
        .driver = {
                .name   = "hisi-sfc-v3xx",
-               .acpi_match_table = ACPI_PTR(hisi_sfc_v3xx_acpi_ids),
+               .acpi_match_table = hisi_sfc_v3xx_acpi_ids,
        },
        .probe  = hisi_sfc_v3xx_probe,
 };