Data converting migrations was wrong. Fixed

diff --git a/db/migrate/20130218141258_convert_closed_to_state_in_issue.rb b/db/migrate/20130218141258_convert_closed_to_state_in_issue.rb
index 0614a5c..9fa9620 100644 (file)
--- a/db/migrate/20130218141258_convert_closed_to_state_in_issue.rb
+++ b/db/migrate/20130218141258_convert_closed_to_state_in_issue.rb
@@ -1,14 +1,14 @@
 class ConvertClosedToStateInIssue < ActiveRecord::Migration
   def up
     Issue.transaction do
-      Issue.where(closed: true).update_all("state = 'closed'")
-      Issue.where(closed: false).update_all("state = 'opened'")
+      Issue.where(closed: true).update_all(state: :closed)
+      Issue.where(closed: false).update_all(state: :opened)
     end
   end
 
   def down
     Issue.transaction do
-      Issue.where(state: :closed).update_all("closed = 1")
+      Issue.where(state: :closed).update_all(closed: true)
     end
   end
 end

diff --git a/db/migrate/20130218141327_convert_closed_to_state_in_merge_request.rb b/db/migrate/20130218141327_convert_closed_to_state_in_merge_request.rb
index 5e7477d..ebb7ae5 100644 (file)
--- a/db/migrate/20130218141327_convert_closed_to_state_in_merge_request.rb
+++ b/db/migrate/20130218141327_convert_closed_to_state_in_merge_request.rb
@@ -1,9 +1,9 @@
 class ConvertClosedToStateInMergeRequest < ActiveRecord::Migration
   def up
     MergeRequest.transaction do
-      MergeRequest.where(closed: true, merged: true).update_all("state = 'merged'")
-      MergeRequest.where(closed: true, merged: true).update_all("state = 'closed'")
-      MergeRequest.where(closed: false).update_all("state = 'opened'")
+      MergeRequest.where(closed: true, merged: true).update_all(state: :merged)
+      MergeRequest.where(closed: true, merged: false).update_all(state: :closed)
+      MergeRequest.where(closed: false).update_all(state: :opened)
     end
   end
 

diff --git a/db/migrate/20130218141344_convert_closed_to_state_in_milestone.rb b/db/migrate/20130218141344_convert_closed_to_state_in_milestone.rb
index 7809666..1978ea8 100644 (file)
--- a/db/migrate/20130218141344_convert_closed_to_state_in_milestone.rb
+++ b/db/migrate/20130218141344_convert_closed_to_state_in_milestone.rb
@@ -1,14 +1,14 @@
 class ConvertClosedToStateInMilestone < ActiveRecord::Migration
   def up
     Milestone.transaction do
-      Milestone.where(closed: false).update_all("state = 'opened'")
-      Milestone.where(closed: false).update_all("state = 'active'")
+      Milestone.where(closed: true).update_all(state: :closed)
+      Milestone.where(closed: false).update_all(state: :active)
     end
   end
 
   def down
     Milestone.transaction do
-      Milestone.where(state: :closed).update_all("closed = 1")
+      Milestone.where(state: :closed).update_all(closed: true)
     end
   end
 end